Question

I have notes attribute in Product model with text “something, something else”.
In views I wanted see:

<div>
  <span>Something</span>
  <span>Something else</span>
</div>

Also I have working code, but I want refactor with decorator(draper) or maybe use helpers.

%div
  - product.notes.split(/,/).each do |e|
    %span= e.strip.capitalize

In decorator:

def notes_list
  model.notes.split(/,/).each do |e|
    h.content_tag(:span, e.strip.capitalize)
  end
end

In views:

%div
  = product.notes_list

(or analog in helpers:

  def notes_list(product)
    product.notes.split(/,/).each do |element|
      content_tag(:span, element.strip.capitalize)
    end
  end

call:

%div
  = notes_list(product)

)

But this returns

    <div>

 "  
                       ["something", " something else"]
                          "
    </div>

What is wrong?

Answer 1

your notes_list is returning product.notes.split(/,/)

Try

def notes_list(product)
  result = product.notes.split(/,/).inject([]) do |result, element|
    result << content_tag(:span, element.strip.mb_chars.capitalize)
  end
  result.join("\n")
end