Question

i have one array this array contain Question Objects so here i need to change the positions for array

Question *que=[[Question alloc]init];

que=[myarray objectAtIndex:1];

Question *que1=[[Question alloc]init];
que1=[myarray objectAtIndex:2];

here i need to inter change objects each other some 

[que1 setValue: que.name forKey:@"Name"];

[myarray relplaceObjectAtIndex:2 withObject:que1];

is it right way to set value same objectValues

Please guide me hoe can inter change value.

Thanks for advance

Answer 1

There are significant issues with your code here:

1. This statement:

   Question *que = [[Question alloc] init];
   

   Allocates a new Question instance and assigns it to the variable que. When you do:

   que = [myarray objectAtIndex:1];
   

   You are overwriting the Question instance that you just allocated, effectively leaking memory (because you never released it). This won’t be a problem if you are using ARC but nevertheless it is something to be mindful of because with or without ARC it is pointless. You did this twice, once for que and once for que1. Since you don’t actually need to allocate and initialise a new Question instance, you can just do:

   Question *que = [myarray objectAtIndex:1];
   

2. You obtain a reference to a Question object and assign it to que1. Then you mutate it and want to put it back into the array. This is pointless because the array already holds a reference to the same Question instance that you obtained with objectAtIndex:.

3. You haven’t really explained what you are trying to do. Your entire code basically boils down to:

   [[[myarray objectAtIndex:2] setValue:[[myarray objectAtIndex:1] name] forKey:@"Name"];