Question

I have one (for me) strange problem.
I have pop under that open one url. i need to make when user click on some flashplayer (who is in div)
I put javascript code

<script type="text/javascript">
    $("player").click(myfunc());
</script>


<script type="text/javascript">
    document.getElementById('player').addEventListener('click', myfunc(), false);
</script>

But there is problem.. this not work on click (when user click on #player), this work when user load page ( onload ) and i dont need that, i need on click to start function…
Where is the problem?

Answer 1

Firstly, you appear to be missing the # character in your jQuery selector (I’m assuming it’s meant to be an ID selector because you also gave an example using getElementById), so it’s currently looking an element called player, rather than an element with ID “player”.

Secondly, you don’t want to execute the myfunc function when you pass it to the click function. Instead, you want to pass a reference to the function (note the lack of parentheses):

$("#player").click(myfunc);

The same is true for your second example, but you are right in that when using getElementById you pass in the string without the # character:

document.getElementById('player').addEventListener('click', myfunc, false);