Question

i have pagination system on my echo results however, the page numbers are being echo’ed underneath eachother

e.g.

                              1
                2 3 4 5

this is my code:

for($i=0;$i < $count1;$i=$i+$limit)
 {
if($i <> $start)
{       
    echo "<a href='view.php?search=$search&start=$i&limit=$limit&price=$price&category=$category'><font face='Verdana' size='2'><b>&nbsp;$l&nbsp;</b></font></a> ";
}
else
{
    echo "<center><font face='Verdana' size='4' color=#2E9AFE ><b>&nbsp;$l&nbsp;</b></font></center>";
}        

MODIFIED CODE:

$i=0;
 $l=1;
   echo "<p align='left'>";
   for($i=0;$i < $count1;$i=$i+$limit)
   {
  if($i <> $start)
   {        
   echo '<a href="view.php?   search=$search&start=$i&limit=$limit&price=$price&category=$category">$i</a>';
}
else
{
   echo '<span class="current">$i</span>';
}        
$l=$l+1;
  }
 echo "</p>";
  }

Answer 1

Here is another way of doing the above, with a few added extras:

$count1 = 10;    
$menu = '';

$link = array(
  'search' => ( isset($search) ? $search : $search = '' ),
  'start' => ( isset($start) ? $start : $start = 0 ),
  'limit' => ( isset($limit) ? $limit : $limit = 1 ),
  'price' => ( isset($price) ? $price : $price = '' ),
  'category' => ( isset($category) ? $category : $category = '' ),
);

foreach( range(0, $count1, $limit) as $i ) {
  $menu .= ( ($link['start'] = $i) == $start ? 
    '<span class="current">'.$i.'</span>' :
    '<a href="view.php?'.http_build_query($link).'">'.$i.'</a>'
  ) . PHP_EOL;
}

echo $menu;

(the above requires php5+)

With regards to neeko’s comment, to seperate the $start variable from the text displayed in the link – all you have to do is either introduce another variable that counts up with each loop – or, as we already have the key of the range array, we can use that:

foreach( range(0, $count1, $limit) as $key => $i ) {
  $menu .= ( ($link['start'] = $i) == $start ? 
    '<span class="current">Page'.($key+1).'</span>' :
    '<a href="view.php?'.http_build_query($link).'">Page'.($key+1).'</a>'
  ) . PHP_EOL;
}

I’ve used $key + 1, because $key will be zero-based (i.e. counting up from Zero) but the +1 just shifts things so we count up from 1 instead.