Question

I have reproduced this function:

function getTables()
  {
      global $db;

      $value = array();
      if (!($result = $db->query('SHOW TABLES'))) {
          return false;
      }
      while ($row = $db->fetchrow($result)) {
          if (empty($this->tables) or in_array($row[0], $this->tables)) {
              $value[] = $row[0];
          }
      }
      if (!sizeof($value)) {
          $db->error("No tables found in database");
          return false;
      }
      return $value;
  }

in this manner:

public function getTables() {

    $value = array();

    $tables = array();

    $sql = "SHOW TABLES";

    if($stmt = $this->connect->prepare($sql)) {
        $stmt->execute(); 
        while( $row = $stmt->fetch_row() ) {        
            if(empty($tables) or in_array($row[0], $tables)) {
                $value[0] = $row[0];
            }       
        }

        $stmt->close();

        if(!sizeof($value)) {
            echo 'The database has no tables';
        }

        return $value;

    } else {

        echo 'Couldn\t query the database';

    }

}

But the second method returns me The database has no tables which is not true because I have one table in the db.

What is it wrong with the second method ?

In case you wonder what connect does :

public $connect;
public function __construct() {
    // Define The Database Connection Or Die If Failed Connecting
    $this->connect = new mysqli(DB_HOST, DB_USER, DB_PASS, DB_NAME) or die(DB_CONNECTION_ERROR_MESSAGE);
}

It make a connection with the database. And prepare() it’s a mysqli statement. I tried with query() too, same result.

Answer 1

Correct code. Use query instead of prepare:

public function getTables()
{
    $value = array();
    $tables = array();

    $sql = "SHOW TABLES";

    if ($res = $this->connect->query($sql))
    {
        while ($row = $res->fetch_row())
        {
            if (empty($tables) or in_array($row[0], $tables))
            {
                $value[] = $row[0];
            }
        }

        if (!sizeof($value))
        {
            echo 'The database has no tables';
        }

        return $value;
    }
    else
    {
        echo 'Could not query the database';
    }
}

If you still want to use prepare then you will also need $stmt->bind_result and $stmt->fetch() instead of fetch_row.