Question

I have searched almost every possible question related to this topic but not able to resolve this issue. Whenever I try to delete items via custom delete button embedded with ListView item, after deleting few items it gives me error of IndexOutOfBound error. I know this error is coming due to list being not able to refresh itself after item has been removed with position. Here is my code:

MainActivity:

import java.util.ArrayList;
import java.util.List;

import android.os.Bundle;
import android.app.Activity;
import android.app.ListActivity;
import android.view.Menu;
import android.widget.ArrayAdapter;

public class MainActivity extends ListActivity 
{

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        //setContentView(R.layout.activity_main);

        ArrayAdapter<Model> adapter = new InteractiveArrayAdapter(this,getModel());
            //adapter.clear();
        setListAdapter(adapter);
    }

    private List<Model> getModel() {
        List<Model> list = new ArrayList<Model>();
        list.add(get("Linux"));
        list.add(get("Windows7"));
        list.add(get("Suse"));
        list.add(get("Eclipse"));
        list.add(get("Ubuntu"));
        list.add(get("Solaris"));
        list.add(get("Android"));
        list.add(get("iPhone"));
        // Initially select one of the items
        //list.get(1).setSelected(true);
        return list;
      }

    private Model get(String s)
    {
        return new Model(s);
    }

}

Code for InteractiveArrayAdapter.java:

public class InteractiveArrayAdapter extends ArrayAdapter<Model> {

    private final List<Model> list;
    private final Activity context;
    private ListView lv;
    private MainActivity ma;


    public InteractiveArrayAdapter(Activity context, List<Model> list)
    {
        super(context, R.layout.rowbuttonlayout, list);
        this.context = context;
        this.list = list;
    }

    static class ViewHolder
    {
        protected TextView text;
        protected Button btn;
    }

    @Override
    public View getView(final int position, View convertView, ViewGroup parent) {
        View view = null;

        if (convertView == null) 
        {
            LayoutInflater inflator = context.getLayoutInflater();
            view = inflator.inflate(R.layout.rowbuttonlayout, null);


            final ViewHolder viewHolder = new ViewHolder();

            viewHolder.text = (TextView) view.findViewById(R.id.label);
            viewHolder.btn = (Button) view.findViewById(R.id.button1);

            viewHolder.btn.setOnClickListener(new OnClickListener()
            {
                public void onClick(View v)
                {

                        list.remove(position);
                        notifyDataSetChanged();  

                }

            });

            view.setTag(viewHolder);
            viewHolder.btn.setTag(list.get(position));
        } //when convertView = null
        else 
        {
            view = convertView;
            ((ViewHolder) view.getTag()).btn.setTag(list.get(position));
            //((ViewHolder) view.getTag()).text.setTag(list.get(position));
        }
        ViewHolder holder = (ViewHolder) view.getTag();
        holder.text.setText(list.get(position).getName());
        //holder.btn.setChecked(list.get(position).isSelected());
        return view;
    }

    @Override
    public int getCount()
    {
        return list.size();
    }

    @Override
    public long getItemId(int position) {
        return position;
    }

    @Override
    public Model getItem(int position) {
        return (null==list)? null: list.get(position);
    }


}

Code for Model Class:

public class Model 
{
    private String name;

    public Model(String name) {
    this.name = name;

    }

    public String getName() {
    return name;
    }

    public void setName(String name) {
    this.name = name;
    }
}

Any help regarding this would be great.

Answer 1

Uncomment the following line

    //((ViewHolder) view.getTag()).text.setTag(list.get(position));

Replace your remove statement with the following one.

    list.remove(viewHolder.btn.getTag());