Question

I have the below code but it lives on after the queue is empty, any insights:

def processor():
   while(1>0):
    if queue.empty() == True:  
    print "the Queue is empty!"  
    break
   source=queue.get()
   page = urllib2.urlopen(source)
   print page   

def main:
   for i in range(threads):  
    th = Thread(target=processor)  
    th.setDaemon(True)  
    th.start()  
   queue.join()  

It prints queue empty as many times as I have threads and just stands there doing nothing.

Answer 1

You need to call queue.task_done() after printing the page, otherwise join() will block. Each thread, after using get() must call task_done().

See documentation for queue