Question

I have the class Furniture with:

Furniture.h:

#include <iostream>
#include <string>
using namespace std;

class Furniture {
public:
    Furniture();
    ~Furniture();
    void setname(string name);
    void setprice(double price);
    double getprice();
    string getname();
    virtual void printSpecs();
private:
    string name;
    double price;
protected:
    static int NumberOfItems;
    int Id;

};

furniture.cpp:

#include "furniture.h"

Furniture::Furniture() {
}
Furniture::~Furniture() {
}
void Furniture::setname(string name) {
    this->name = name;
}
string Furniture::getname()
{
    return this->name;
}
void Furniture::setprice(double price) {
    this->price = price;
}
double Furniture::getprice() {
    return this->price;
}
void Furniture::printSpecs() {
    cout<<"Price: "<<this->price<<endl;
    cout<<"Name: "<<this->name<<endl;
}

int main() {
    Furniture *model = new Furniture();
    model->setname("FinalDestiny");
    model->setprice(149.99);
    model->printSpecs();
    delete model;
}

Everything works fine but I want to add multiple furniture items with the same class and just update the NumberOfItems. Is there any way to do that?

Also, is my code ok? I mean, how can I improve it? I’m quite new to OOP and I’d like to learn some good practices.

Thanks.

Answer 1

The idea is conceptually broken. You cannot do that; you really need different objects.

Alternatively, if you really want to have multiple identical items, you can create one item and create multiple pointers to it, and maintain a separate count for the number of active items. A shared_ptr does that for instance.

That said, your code shouldn’t use pointers at all, this is a common anti-pattern in C++ code. Furthermore, your code probably shouldn’t have setters, provide a proper constructor instead:

int main() {
    Furniture model("FinalDestiny", 149.99);
    model.printSpecs();
}

Much shorter, simpler, and no possiblity of leaking memory.