Question

I have the following C# code:

public string TargetDate()
{
    SqlConnection con = 
        new SqlConnection("Server=localhost;Database=Timer;Trusted_Connectopn=True");
    SqlCommand cmd = new SqlCommand("select * from Timer");
    con.Open(); 

    DataSet ds = new DataSet(cmd,con); 
    SqlDataAdapter da = new SqlDataAdapter(); 
    da.Fill(ds); 
    con.Close(); 
}

but I get error at the: new DataSet(cmd,con); ...

the error: CS1502: The best overloaded
method match for

'System.Data.DataSet.DataSet(System.Runtime.Serialization.SerializationInfo,

System.Runtime.Serialization.StreamingContext)’
has some invalid arguments

What is could be the problem?

Answer 1

Try this:

SqlConnection con = new SqlConnection
    ("Server=localhost;Database=Timer;Trusted_Connection=True");

SqlCommand cmd = new SqlCommand("select * from Timer", con);

con.Open();

DataSet ds = new DataSet();
SqlDataAdapter da = new SqlDataAdapter(cmd);
da.Fill(ds);

con.Close(); 

This is even better:

DataTable dataTable = new DataTable();
using(SqlConnection connection = new SqlConnection("Server=localhost;Database=Timer;Trusted_Connection=True"))
using(SqlCommand command = connection.CreateCommand())
{
    command.CommandText = "select * from Timer";
    connection.Open();
    SqlDataReader reader = command.ExecuteReader();
    dataTable.Load(reader);
}