Question

I have the following code:

class TestClass
{
    public string StringValue {
        get; set;
    }
    public int IntValue {
        get; set;
    }
}

class MainClass
{
    private readonly List<TestClass> MyList;

    public MainClass()
    {
        MyList = new List<TestClass>();
    }

    public void RemoveTestClass(string strValue)
    {
         int ndx = 0;

         while (ndx < MyList.Count)
         {
             if (MyList[ndx].StringValue.Equals(strValue))
                 break;
             ndx++;
         }
         MyList.RemoveAt(ndx);
    }

    public void RemoveTestClass(int intValue)
    {
         int ndx = 0;

         while (ndx < MyList.Count)
         {
             if (MyList[ndx].IntValue == intValue)
                 break;
             ndx++;
         }
         MyList.RemoveAt(ndx);
    }
}

What I would like to know is if there is a simpler way, perhaps using LINQ, to replace the while loops in the 2 RemoveTestClass functions, rather then iterating through each element, like I’m doing?

Answer 1

You can use List<T>.FindIndex:

myList.RemoveAt(MyList.FindIndex(x => x.StringValue == strValue));

You may also want to handle the case where the element is not found:

int i = myList.FindIndex(x => x.StringValue == strValue);
if (i != -1)
{
    myList.RemoveAt(i);
}