Question

i have the following code part in one of my classes:

                $l = new Location();
                $result = $l->getLocIdsbyCity($city); // returns csv
                $ids = explode(',', $result);

                $where = 'LOC_ID = ' . $ids[0];
                unset($ids[0]);

                foreach ($ids as $id) {
                    $where .= ' OR LOC_ID = ' . $id;
                }

                $select->where($where);

Is there an more “elegant” way to build the select stmt? I need all records with one of the provided ids..

Answer 1

Assuming your csv is injection safe (contains trusted values and no user-provided input):

            $l = new Location();
            $result = $l->getLocIdsbyCity($city); // returns csv
            $where = "LOC_ID IN ($result)";
            $select->where($where);

If it’s not, you should explode it, mysql_real_escape_string each value and implode back.