Question

I have the following script to ask the user to confirm clicking a button depending on a system setting.

The system setting is stored in a hidden field set from code behind.

Markup:

<asp:HiddenField ID="hfConfirmOnApproval" runat="server" Value="False" />

cs:

//Read the confirm on approval setting
hfConfirmOnApproval.Value = Objects.Engine.Settings.Instance.ConfirmOnApproval.ToString();

js:

//Get whether to confirm on approval
var _confirmOnApproval = new Boolean($('#hfConfirmOnApproval').val());

if ( _confirmOnApproval ? confirm('Are you sure you want to approve this item?') : true ) 
{

    // do work

}

The problem is that the confirm message box is being displayed even though _confirmOnApproval is set to false?

I only want the message box to appear if its set to true.

The _ConfirmOnApproval is false at the moment

SOLUTION:

js:

var _confirmOnApproval = $('#<%=hfConfirmOnApproval.ClientID %>').val() == "True" ? true : false;

if ( _confirmOnApproval  ? confirm('Are you sure you want to approve this item?') : true ) {
//Do work
}

Answer 1

It’s because you’ve used new Boolean to create a Boolean object, and typeof _confirmOnApproval will return “Object”:

var x = new Boolean(false); //Boolean object
if(x) {
   console.log("hello"); //This will always execute
}
var y = false; //Literal boolean primitive
if(y) {
   console.log("hello"); //This won't
}

You could get rid of new Boolean and just compare the value:

if(_confirmOnApproval == "False")