Question

I have the following segment of code where m_edit is a CEdit control:

TCHAR lpsz[MAX_PATH+1];

// get the edit box text
m_edit.GetLine(0,lpsz, MAX_PATH); 

This works perfectly on computers running Windows XP and earlier. I have not tested this in Vista, but on Windows 7, lpsz gets junk unicode characters inserted into it (as well as the actual text sometimes). Any idea as to what is going on here?

Answer 1

Since you’re using MFC, why aren’t you taking advantage of its CString class? That’s one of the reasons many programmers were drawn to MFC, because it makes working with strings so much easier.

For example, you could simply write:

int len = m_edit.LineLength(m_edit.LineIndex(0));
CString path;
LPTSTR p = path.GetBuffer(len);
m_edit.GetLine(0, p, len);
path.ReleaseBuffer();

(The above code is tested to work fine on Windows 7.)

Note that the copied line does not contain a null-termination character (see the “Remarks” section in the documentation). That could explain the nonsense characters you’re seeing in later versions of Windows.