Question

I have the following simple function:

    private void EnableDisable941ScheduleBButton()
    {
        if (this._uosDepositorFrequency.Value != null)
            this._btnScheduleB.Enabled = ((int)this._uosDepositorFrequency.Value == 0);
    }

It’s a member of a Winform class which I’m trying to split into a passive view and presenter. It’s obvious there is business logic tangled together with UI wiring. I’m just not sure of the best way to separate them.

To give a little context, the function is called from three locations in the form. _uosDepositorFrequency is a radiobutton group with only two buttons.

Any ideas?

Update:

Ok, maybe it isn’t as obvious as I thought. The business rule states that if an employer makes semiweekly deposits (_uosDepositorFrequency.Value = 0) they are required to fill out a Schedule B form.

Answer 1

First I’d like to thank all those who responded to my question.

I spent some time working on this and I believe I’ve come up with a solution.

First I exposed _uosDepositorFrequency.Value and _btnScheduleB.Enabled as public properties and update the view interface I also took a few moments to define an enum for the deposit frequencies.

    public bool EnableScheduleB
    {
        get
        {
            return _btnScheduleB.Enabled;
        }
        set
        {
            _btnScheduleB.Enabled = value;
        }
    }

    public DepositFrequency DepositorFrequency
    {
        get
        {
            return (DepositFrequency)_uosDepositorFrequency.Value;
        }
        set
        {
            _uosDepositorFrequency.Value = (int)value;
        }
    }

Then I copied the body of the original function to my presenter and modified it to use the properties I just created. The null checking in the original function turned out to be unnecessary because the _uosDepositorFrequency control is initialized elsewhere.

    public void UpdateScheduleBStatus()
    {
        ReturnView.EnableScheduleB = ReturnView.DepositorFrequency == DepositFrequency.Semiweekly;
    }

Finally the _uosDepositorFrequency_ValueChanged event handler was updated to call UpdateScheduleBStatus.

    private void _uosDepositorFrequency_ValueChanged(object sender, System.EventArgs e)
    {
        Presenter.UpdateScheduleBStatus();
    }

Comments welcome.