Question

I have the following which is fairly slow. How can I speed it up?

(it scans a directory and makes headers out of the foldernames and retrieves the pdf files from within and adds them to lists)

$directories= array_diff(scandir("../pdfArchive/subfolder", 0), array('..', '.'));
  foreach ($directories as $v) {
    echo "<h3>".$v."</h3>";
    $current = array_diff(scandir("../pdfArchive/subfolder/".$v, 0), array('..', '.'));
    echo "<ul style=\"list-style-image: url(/images/pdf.gif); margin-left: 20px;\">";
    foreach ($current as $vone) {
      echo "<li><a target=\"blank\" href=\"../pdfArchive/subfolder/".$vone."\">".str_replace(".pdf", "", $vone)."</a>";
      echo "</li><br>";
    }
    echo "</ul>";
  }

Answer 1

I’m not sure how fast array_diff() is when the array is very large, isn’t it faster to simply add a separate check and make sure that ‘.’ and ‘..’ is not the returned name?

Other than that, I can’t see there being anything really wrong.

What did you test to consider the current approach slow?