Question

I have this code:

WItem.h

#include <vector>
#include <string>

typedef struct iteminfo {
int rowid;
   char* item;
   int type;
   int extra;
   int objectid;
} item;


class CItem {
 public:
    void push(int rowid, char* item, int type, int extra, int objectid);
    std::vector<iteminfo> data;
};

WItem.cpp

#include "witem.h"

void CItem::push(int rowid, char* item, int type, int extra, int objectid) {
   iteminfo* temp = new iteminfo;
   temp->rowid = rowid;
   temp->item = item;
   temp->type = type;
   temp->extra = extra;
   temp->objectid = objectid;

   this.data.push_back(temp);
}

And I get these errors:

• `data’ is not a type
• request for member of non-aggregate type before ‘.’ token

And I have no idea what is wrong.

Answer 1

1. this.data is wrong, needs to be either just data or this->data

2. data is a vector of iteminfo and temp is iteminfo * i.e. a pointer. You don’t need to use new here, you should just create the item “on the stack” and then use push_back to insert a copy of it into your vector.

3. As this is likely to not be C at all, there is no need for the typedef but even more so use std::string for strings not char *. You are going to get into a lot of mess maintaining these pointers.

4. Preferably do not use item both as a type and a member. It’s legal but will get confusing in your code.

5. Ideally make data a private member of CItem (Incidentally if you are using the class names item and CItem just to reproduce your problem here that’s fine but in real code they are poor class names, choose something more descriptive).