Question

I have this function sentanceParse with a string input which returns a list. The input might be something like “Hello my name is Anton. What’s your name?” and then the return value would be a list containing “Hello my name is Anton” and “What’s your name?”. However, this is not what happens. It seems as if the whitespaces in the sentences are treated like a separator and therefore the return is rather “Hello”, “my”, “name” etc instead of what I expected.

How would you propose I solve this?

As I am not a 100% sure the problem does not lie within my code, I will add that to the post as well:

Main:

list<string> mylist = sentanceParse(textCipher);
list<string>::iterator it;
for(it = mylist.begin(); it != mylist.end(); it++){
    textCipher = *it;
    cout << textCipher << endl; //This prints out the words separately instead of the entire sentances.

sentanceParse:

list<string> sentanceParse(string strParse){
    list<string> strList;
    int len = strParse.length();
    int pos = 0;
    int count = 0;
    for(int i = 0; i < len; i++){
        if(strParse.at(i) == '.' || strParse.at(i) == '!' || strParse.at(i) == '?'){
            if(i < strParse.length() - 1){
                while(i < strParse.length() - 1 && (strParse.at(i+1) == '.' || strParse.at(i+1) == '!' || strParse.at(i+1) == '?')){
                    if(strParse.at(i+1) == '?'){
                        strParse.replace(i, 1, "?");
                    }
                    strParse.erase(i+1, 1);
                    len -= 1;
                }
            }
            char strTemp[2000];
            int lenTemp = strParse.copy(strTemp, i - pos + 1, pos);
            strTemp[lenTemp] = '\0';
            std::string strAdd(strTemp);
            strList.push_back(strAdd);
            pos = i + 1;
            count ++;
        }
    }

    if(count == 0){
        strList.push_back(strParse);
    }

    return strList;
}

Answer 1

Your implementation of sentence parse is wrong, here is a simpler correct solution.

std::list<std::string> sentence_parse(const std::string &str){
    std::string temp;
    std::list<std::string> t;

    for(int x=0; x<str.size();++x){
       if(str[x]=='.'||str[x]=='!'||str[x]=='?'){
           if(temp!="")t.push_back(temp);//Handle special case of input with
                                         //multiple punctuation Ex. Hi!!!!
           temp="";
       }else temp+=str[x];
    }
    return t;
}

EDIT:

Here is a full example program using this function. Type some sentences in your console, press enter and it will spit the sentences out with a newline separating them instead of punctuation.

#include <iostream>
#include <string>
#include <list>
std::list<std::string> sentence_parse(const std::string &str){
    std::string temp;
    std::list<std::string> t;

    for(int x=0; x<str.size();++x){
        if(str[x]=='.'||str[x]=='!'||str[x]=='?'){
            if(temp!="")t.push_back(temp);//Handle special case of input with
                                          //multiple punctuation Ex. Hi!!!!
            temp="";
        }else temp+=str[x];
    }
    return t;
}
int main (int argc, const char * argv[])
{
    std::string s;

    while (std::getline(std::cin,s)) {       
        std::list<std::string> t= sentence_parse(s);
        std::list<std::string>::iterator x=t.begin();
        while (x!=t.end()) {
             std::cout<<*x<<"\n";
            ++x;
        }

    }

    return 0;
}