Question

I have this PHP code:

if ($username) {
    if ($news == 1)
        $int = "9";
    if ($news == 0)
        $int = "12";
}
else
    $int = "9";

$query = mysql_query("SELECT * FROM files WHERE active='1' ORDER BY id DESC LIMIT $int");
require ("scripts/connect.php");
$numrows = mysql_num_rows($query);

But then I get this error (Note the line starting with $numrows is line 69):

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /Applications/XAMPP/xamppfiles/htdocs/Site/index.php on line 69

I have tried many ways of changing the number to no avail. Please help! Thanks!

Answer 1

If your scripts/connect.php is responsible for establishing database connection, then I belive mysql_query() should be below it, not above as it is now. I also recommend using mysql_error() and always check return values for errors, as assumptions like “query is always successful” are no-no approach and will hit you badly in less expected moment.

require ("scripts/connect.php");
$query = mysql_query("SELECT * FROM files WHERE active='1' ORDER BY id DESC LIMIT $int");
if( $query ) {
  $numrows = mysql_num_rows($query);
  ...
} else {
   die( mysql_error() );
}

Please note mysql extension is deprecated. Switch to mysqli or something more sophisticated like PDO as soon as you can.