Home/ Questions/Q 6801781
In Process

The Archive Base Latest Questions

Editorial Team
  • 0
Asked: 2026-05-26T19:08:32+00:00

I have this php page that posts to itself and then it checks weather

  • 0

I have this php page that posts to itself and then it checks weather if to login someone or not. The problem I am having is that if it logins… then it still shows the username and password textboxes.. but if i refresh they go away and now the welcome thing comes up thanks to the session.

What i want is to once the submit is clicked and it logs the person in to immediately not show the textboxes (username, password) and show the welcome message. Right now i have to refresh.

Please note i am new to PHP and any wise advise will be much appreciated.

    <?php 

        echo "<form method=\"post\" action=\"index.php?form_type=$page_vals\">";
        echo "<body>";

        //Start session
         session_start();

       //Check whether the session variable SESS_MEMBER_ID is present or not
       if(!isset($_SESSION['SESS_MEMBER_ID']) || (trim($_SESSION['SESS_MEMBER_ID']) == '')) {

         extract($_POST);

       $username = "";
       $password = "";
       $userrole = "";
       $userid ="";

       $login_query = "SELECT user_id, user_role, user_username FROM users WHERE user_username = '$_POST[logInUsername]' AND user_password = '$_POST[logInPassword]'";

        if(!($database = mysql_connect("localhost","root","")))
                die("<p>Could not connect to database</p></div></div>
                                 </body>
                                </html>");

            if(!mysql_select_db("mydatabase", $database))
                die("<p>Could not open my databases database</p></div>
               </div>
                                 </body>
                                </html>");

                if(!($result = mysql_query($login_query, $database)))
                {
                    print("Could not execute query!<br/>");
                    die(mysql_error()."</div>
               </div>            
                                 </body>
                                </html>");
                }


            if (mysql_num_rows($result) == 0) {
               print("Please verify your login information<br/>");
                }


            while ($row = mysql_fetch_assoc($result)) {
                  $username = $row["user_username"];
                  $userrole = $row["user_role"];
                  $userid = $row["user_id"];
              }

            echo "Hello - '$username'";
            mysql_close($database);

            session_regenerate_id();

            $_SESSION['SESS_MEMBER_ID'] = $userid;
            $_SESSION['SESS_NAME'] = $username;

            //Write session to disc
            session_write_close();

                   echo '<div id="login" class="login">
        <label for="login">User Name</label>
        <input type="text" name="logInUsername" />
        <label for="Password">Password</label>
        <input type="password" name="logInPassword" />
        <input type="submit" value="Submit" class="button" />
        </div>';
        }
   else 
   {
    $sessionName = $_SESSION['SESS_NAME'];
     echo '<div id="login" class="login">
        <label for="welcome">Welcome '. $sessionName.'!</label>
        </div>';
   }

    ?>
Share

Leave an answer

You must login to add an answer.

Need An Account,

1 Answer

  1. Editorial Team

    Problem here is just your code is not in sequence. I have corrected Try it now.

    <?php 
   session_start();

    echo "<body>";

    //Start session
  //print_r($_SESSION);exit;

   //Check whether the session variable SESS_MEMBER_ID is present or not

     extract($_POST);

   $username = "";
   $password = "";
   $userrole = "";
   $userid ="";
if(isset($_POST))
{
   $login_query = "SELECT reg_id, role_id, f_name FROM registration WHERE f_name = '$_POST[logInUsername]' AND password = '$_POST[logInPassword]'";

    if(!($database = mysql_connect("sunlinux","pukhraj","pukhraj123")))
            die("<p>Could not connect to database</p></div></div>
                             </body>
                            </html>");

        if(!mysql_select_db("testbaj", $database))
            die("<p>Could not open my databases database</p></div>
           </div>
                             </body>
                            </html>");

            if(!($result = mysql_query($login_query, $database)))
            {
                print("Could not execute query!<br/>");
                die(mysql_error()."</div>
           </div>            
                             </body>
                            </html>");
            }


        if (mysql_num_rows($result) == 0) {
           print("Please verify your login information<br/>");
            }


        while ($row = mysql_fetch_assoc($result)) {
              $username = $row["f_name"];
              $userrole = $row["role"];
              $userid = $row["reg_id"];
          }

         $_SESSION['SESS_MEMBER_ID'] = $userid;
        $_SESSION['SESS_NAME'] = $username;
   }
   if(!isset($_SESSION['SESS_MEMBER_ID']) || (trim($_SESSION['SESS_MEMBER_ID']) == '')) {

        echo "Hello - '$username'";
        mysql_close($database);

        session_regenerate_id();



        //Write session to disc
        session_write_close();

        echo "<form method=\"post\" ><div id=\"login\" class=\"login\">
        <label for=\"login\">User Name</label>
        <input type=\"text\" name=\"logInUsername\" />
        <label for=\"Password\">Password</label>
        <input type=\"password\" name=\"logInPassword\" />
        <input type=\"submit\" value=\"Submit\" class=\"button\" />
        </div>";
        }
   else 
   {
    $sessionName = $_SESSION['SESS_NAME'];
     echo "<div id=\"login\" class=\"login\">
        <label for=\"welcome\">Welcome '$sessionName' !</label>
        </div>";
   }

?>

    Small changes :

    1. Just plase form tag at appropriate place.
    2. Never mix code after post and before post.
    3. here all database stuff should be execute after submit so I enclosed them in condition if(isset($_POST))
    4. due to nonlinearity of code it was creating session after one more refresh after post data. Now corrected.

    for message :

    do below changes :

    1. give name to submit button <input type=\"submit\" name=\"submit\" value=\"Submit\" class=\"button\" />

    2. replace first if condition with if(isset($_POST['submit']))

    • 0