Question

I have this PHP:

<?php

$data = file_get_contents('http://newsrss.bbc.co.uk/rss/sportonline_uk_edition/football/rss.xml');

$xml = simplexml_load_string($data);

$data1 = file_get_contents('http://www.skysports.com/rss/0,20514,11661,00.xml');

$xml1 = simplexml_load_string($data1);

$master[0] = $xml;
$master[1] = $xml1;

echo json_encode($master);

?>

And this jQuery:

    var myRSS =[];

function rssReader() {

    console.log('ran');

    $.getJSON('bbc.php', function(data){
        console.log(data);
        $.each(data[0].channel.item, function(index, item){
            // check if item title is stored in the array   
            if (jQuery.inArray(item.title, myRSS) != -1) { 
                //do nothing
            } else {
                // save item title in the array
                myRSS.push(item.title);

                // publish item  
                $('.container').prepend("<a target='_BLANK' href='" + item.link + "' class='title' data-date='" + item.pubDate + "'>" + item.title + "</a>");
                $("title").text('EMG: ' + item.title);
                $('#loader').remove();
            }
        });

        $.each(data[1].channel.item, function(index, item){
            // check if item title is stored in the array   
            if (jQuery.inArray(item.title, myRSS) != -1) { 
                //do nothing
            } else {
                // save item title in the array
                myRSS.push(item.title);

                // publish item  
                $('.container').prepend("<a target='_BLANK' href='" + item.link + "' class='title' data-date='" + item.pubDate + "'>" + item.title + "</a>");
                $("title").text('EMG: ' + item.title);
            }
        });

    });

}

rssReader();

setInterval(rssReader, 10000);

There seems to be a lot of repeated code and therefore isn’t very DRY programming. The returned JSON actually has the same structure, from BBC and Sky Sports so there must be a more efficient way of writing this.

Thanks

Answer 1

you can cut your jquery down to this(havent tested it there might be a typo):

  var myRSS =[];

    function rssReader() {

        console.log('ran');

        $.getJSON('bbc.php', function(data){
            console.log(data);
            $.each(data[0].channel.item, function(index, item){
                linkhandler(item)
                if (jQuery.inArray(item.title, myRSS) == -1) { 
                    $('#loader').remove();
                }
            });

            $.each(data[1].channel.item, function(index, item){
               linkhandler(item)
            });

        });

    }
    function linkhandler(item)
    { // check if item title is stored in the array   
       if (jQuery.inArray(item.title, myRSS) == -1) { 
             // save item title in the array
             myRSS.push(item.title);
             $('.container').prepend("<a target='_BLANK' href='" + item.link + "' class='title' data-date='" + item.pubDate + "'>" + item.title + "</a>");
             $("title").text('EMG: ' + item.title);
       }
    }
    rssReader();

    setInterval(rssReader, 10000);