Question

I have this query and it’s not updating into the database. The given “where” clause is valid. When I run the query independently, it works fine but in this Procedure it’s not working. There is no exception or no error. Could you guys help me in figuring out where the problem is?

EXECUTE IMMEDIATE 'UPDATE  ' || dest || ' SET COUNTRY_CODE = :v1 WHERE col_id = :v2'
          USING l_vc_CountryCode, l_vc_ColId;

if SQL%ROWCOUNT > 1 THEN
          inserts := inserts + 1;
          counter := counter + 1;
          IF counter > 500 THEN
            counter := 0;
            COMMIT;
          END IF;
        END IF;

I didn’t write the commit code before. Just to clarity.

Answer 1

I suppose that col_id is the primary key. So in the update statement

EXECUTE IMMEDIATE 'UPDATE  ' || dest || ' SET COUNTRY_CODE = :v1 WHERE col_id = :v2'
          USING l_vc_CountryCode, l_vc_ColId;

you are always updating at most one row and thus the condition

SQL%ROWCOUNT > 1

is never true ( 1 is not > 1 )

So if you don’t have any other commit statement in your procedure, you will never commit those updates.

By the way: what is the purpose of this

if SQL%ROWCOUNT > 1 THEN
          inserts := inserts + 1;
          counter := counter + 1;
          IF counter > 500 THEN
            counter := 0;
            COMMIT;
          END IF;
        END IF;

why don’t you just commit at the end of your work?