Question

I have this repetitive code in all the controllers:

        var user = Session["_User"] as User;

        if (user== null)
        {
            return RedirectToAction("Index");
        }

How can I refactor this? should i add this to an attribute or make a Session Wrapper?

What would be the best approach?

Answer 1

extend your all controllers with a MasterController and override OnActionExecuting method as follows

public class MasterController : Controller
{
    protected override void OnActionExecuting(ActionExecutingContext filterContext)
    {
        var user = Session["_User"] as User;

        if (user== null)
        {
            if(filterContext.ActionDescriptor.ActionName != "Index" || filterContext.ActionDescriptor.ControllerDescriptor.ControllerName != "ControllerThatContainIndexAction")
            {
                 filterContext.Result = this.RedirectToAction("Index");
                 return;
            }
        }
        base.OnActionExecuting(filterContext);
    }
}