Question

I have this SQL Server query which is returning Conversion failed when converting date and/or time from character string.

(
    @numberRecords int,
    @date varchar(12)
)

AS
SET ROWCOUNT @numberRecords
SELECT re.ID, re.RecentChangeTypeID, re.LogID, re.RevisionID
FROM RecentChanges re
    FULL OUTER JOIN Revisions rev
        ON re.RevisionID = rev.ID
    FULL OUTER JOIN Logs lg
        ON re.LogID = lg.ID
WHERE convert(datetime, rev.Timestamp) >= '@date' OR
      convert(datetime, lg.Timestamp) >= '@date';
RETURN

The date parameter returns a string value in the format “dd-MM-yyyy”. What may be the cause?

Answer 1

Don’t put your @date parameter inside single quotes – it’s being interpreted as a string instead of as a parameter.

As written you are trying to make '@date' a datetime which won’t parse.

That being said, you should probably make the input parameter a datetime in the first place.