Question

I have this stored procedure for Oracle:

create or replace
procedure bns_saa_message_get()  <--- PROBLEM IS HERE BC I HAVE NO PARAMS TO PASS
AS
begin
  select HostNumber, SAAMessage from BNS_SAA_MESSAGES where HostNumber=(select max(HostNumber) from BNS_SAA_MESSAGES);
end;

I get the following error when I try to compile it:

Error(2,31): PLS-00103: Encountered the symbol ")" when expecting one of the following:     <an identifier> <a double-quoted delimited-identifier>    current 

Question:
How do I make a stored procedure where I don’t need to pass any arguments to it?

Answer 1

Remove the brackets:

CREATE OR REPLACE PROCEDURE bns_saa_message_get
AS
BEGIN
   SELECT hostnumber, saamessage
     FROM bns_saa_messages
    WHERE hostnumber = (SELECT MAX (hostnumber) FROM bns_saa_messages);
END;

EDIT:

To answer your second question…

CREATE OR REPLACE PROCEDURE bns_saa_message_get
AS
   v_hostnumber bns_saa_messages.hostnumber%TYPE;
   v_saamessage bns_saa_messages.saamessage%TYPE;
BEGIN
   SELECT hostnumber, saamessage
     INTO v_hostnumber, v_saamessage 
     FROM bns_saa_messages
    WHERE hostnumber = (SELECT MAX (hostnumber) FROM bns_saa_messages);
END;

This assumes you only get one row returned from your query….
If you get more than one row then you’ll have to bulk collect into a collection.