Question

I have this very simple test code:

s="helloCustomer"

is_contain_customer = s=='helloCustomer' || s.include? 'Customer' ? 'YES' : 'NO'

I got error message Unexpected tSTRING_BEG for the 2nd line in the code.

Why?

Answer 1

In addition to the syntax error (you need parentheses around method args if the syntax is ambiguous), your code is not as clear as it could be.

You’re using the higher precedence of || vs ? : to cause the expression to ultimately return ‘YES’ or ‘NO’

For the sake of readability and maintainability, I suggest that you add parentheses to make the intent clear:

is_contain_customer = 
     (s=='helloCustomer' || s.include?('Customer')) ? 'YES' : 'NO'

Also, if you’re using Rails or another MVC system, it’d be better to use your View layer to convert the data (the boolean value) to a string.