Question

I have two array with string values, and one dictionary, im trying to add values from array1 as key and values from array2 as value in dictionary.

what is best practice in this case?
i have tried following

foreach(var i in array1)
{
    foreach(var t in array2)
    dictionary.add(i.value, t.value)
}

Answer 1

Well you could do (in .NET 4):

var dictionary = array1.Zip(array2, (key, value) => new { key, value })
                       .ToDictionary(pair => pair.key, pair => pair.value);

That basically zips together the two arrays, so you end up with a sequence of pairs. You then call the ToDictionary extension method, extracting the key and value from each pair.

Alternatively, you could do it the old-fashioned way:

var dictionary = new Dictionary<string, string>();
for (int i = 0; i < array1.Length; i++)
{
    dictionary[array1[i]] = array2[i]; // Or use Add
}

In both cases you should make sure the arrays are the same length, of course.