Question

I have two IEnumerable<T>s.

One gets filled with the fallback ellements. This one will always contain the most elements. The other one will get filled depending on some parameters and will possibly contain less elements. If an element doesn’t exist in the second one, I need to fill it with the equivalent one of the first one.

This code does the job, but feels inefficient to me and requires me to cast the IEnumerables to ILists or to use a temporary list Person implements IEquatable

IEnumerable<Person> fallBack = Repository.GetPersons(); IList<Person> translated = Repository.GetPersons(language).ToList();  foreach (Person person in fallBack) {     if (!translated.Any(p=>p.equals(person)))         translated.add(person);   } 

Any suggestions?

Answer 1

Try this.

public static IEnumerable<Person> SmartCombine(IEnumerable<Person> fallback, IEnumerable<Person> translated) {   return translated.Concat(fallback.Where(p => !translated.Any(x => x.id.equals(p.id))); }