Question

I have two models

class User < ActiveRecord::Base
  has_one :user_information, :dependent => :destroy
  attr_accessible :email, :name
end

and

class UserInformation < ActiveRecord::Base
  belongs_to :user
  attr_accessible :address, :business, :phone, :user_id
end

after created the user, I created the user information using the new and the create action of my controller:

  def new
         @user = User.find(params[:id])
         @user_information = @user.build_user_information

    respond_to do |format|
      format.html # new.html.erb
      format.json { render json: @user_information }
    end
  end



def create
    @user_information = UserInformation.new(params[:user_information])

    respond_to do |format|
      if @user_information.save
        format.html { redirect_to @user_information, notice: 'User information was successfully created.' }
        format.json { render json: @user_information, status: :created, location: @user_information }
      else
        format.html { render action: "new" }
        format.json { render json: @user_information.errors, status: :unprocessable_entity }
      end
    end
  end

everything works fine, but when I try to update the record I get this error:

RuntimeError in User_informations#edit

Called id for nil, which would mistakenly be 4 -- if you really wanted the id of nil, use object_id

Here are the edit and the update action of my user_information controller

    def edit
        @user_information = UserInformation.find(params[:id])
      end 

  def update
    @user_information = UserInformation.find(params[:id])

    respond_to do |format|
      if @user_information.update_attributes(params[:user_information])
        format.html { redirect_to @user_information, notice: 'User information was successfully updated.' }
        format.json { head :no_content }
      else
        format.html { render action: "edit" }
        format.json { render json: @user_information.errors, status: :unprocessable_entity }
      end
    end
  end

I thought I only have to find the record and edit, but no. Can anyone help me please?

Answer 1

Try to remove belongs_to :user from UserInformation
http://guides.rubyonrails.org/association_basics.html#the-has_one-association

update after discussion:

Your link helper should takes two arguments with @user at first position. (You can see it from result of rake routes | grep user_information)

<%= link_to 'Edit', edit_user_information_path(@user, @user_information) %>

Second of all in your controller

params[:id] # => @user.id
params[:user_information_id] # => @user_information.id

So you should change find to

@user_information = UserInformation.find(params[:user_information_id])