Question

I have two models that are associated via a has_many relationship. E.g.

class Newspaper < ActiveRecord::Base
  has_many :articles
end

class Article < ActiveRecord::Base
  belongs_to :newspaper

  validates :uid, presence: true,
                  uniqueness: { case_sensitive: true }
end

A newspaper is updated several times a day but we only want to construct and add articles to the association that do not already exist. The following code was my first cut of achieving this.

new_articles.each do |article|
  unless newspaper.articles.exists? uid: article.uid
    newspaper.articles.build(uid: article.uid)
  end
end

The newspaper object is either new and unsaved, or retrieved with existing relationships at this point.

My tests indicate that I am able to add two articles to the newspaper that have the same UID using the code above and this is obviously not want I want.

I appears to me that my current code will result in a validation failure upon being saved as the validation looks at uniqueness across the entire articles table and not the association.

What I’m struggling to understand is how the exists? method behaves in this scenario (and why it’s not saving my bacon as I planned). I’m using FactoryGirl to build a newspaper, add an article and then simulate an update containing an article with the same uid as the article I’ve already added. If the code works I should get only one associated article but instead I get two. Using either build or create makes no difference, thus whether the article record is already present in the database does not appear to change the outcome.

Can anyone shed some light on how I can achieve the desired result or why the exists? method is not doing what I expect?

Thanks

Answer 1

The association exists? actually creates a scoped query, as per the association. This is why your existing articles filter doesn’t work.

unless newspaper.articles.exists? uid: article.uid

# `articles.exists?` here will produce this if the newspaper is new 
#   ... WHERE "articles"."newspaper_id" IS NULL AND "articles.uid" = '<your uid>'

# and this, if the newspaper is persisted (with an id of 1)
#   ... WHERE "articles"."newspaper_id" = 1 AND "articles.uid" = '<your uid>'

The case of the new newspaper is clearly wrong, as it would only return articles with a nil newspaper ID. But the persisted case is probably undesirable as well, as it still unnecessarily filters against newspaper ID, when you real concern here is that the UID is unique.

Rather, you probably want simply against Article, rather than scoping the exists? through the association, like:

unless Article.exists? uid: article.uid

---

Concerning your other problem:

this appears to be a FactoryGirl problem where the create method isn’t creating db entries in the same way I can in the irb.

FactoryGirl.create should still abide by validations. It might help to see your test.