Question

I have two queries that I need to combine in LINQ that both actually come from the same table. The reason for this is that one of the queries needs to get the max of a field for each day and then sum the days together where the second query can just sum everything right off the bat. Here is the first query:

var queryDownload = from p in
                        (from p in almdbContext.cl_contact_event
                         where p.time_of_contact >= startDate && p.time_of_contact < endDate && p.input_file_name.Contains(inputFileName) && listName.Contains(listName)
                         group p by new
                         {
                             date = EntityFunctions.CreateDateTime(p.time_of_contact.Value.Year, p.time_of_contact.Value.Month, p.time_of_contact.Value.Day, 0, 0, 0),
                             listName = p.contact_list_name
                         } into g
                         select new
                         {
                             date     = g.Key.date,
                             listName = g.Key.listName,
                             download = g.Max(a => a.total_number_of_records)
                         })
                    group p by p.listName into g
                    select new
                    {
                        listName      = g.Key,
                        totalDownload = g.Sum(a => a.download),
                    };

This is the second:

var queryPenData = from p in almdbContext.cl_contact_event
                   where p.time_of_contact >= startDate && p.time_of_contact < endDate && p.input_file_name.Contains(inputFileName) && listName.Contains(listName)
                   group p by p.contact_list_name into g
                   select new
                   {
                       listName           = g.Key,
                       dials              = g.Sum(a => a.ov_dial_start_time != null ? 1 : 0),
                       agentConnects      = g.Sum(a => a.agent_login_name != null ? 1 : 0),
                       abandons           = g.Sum(a => a.response_status == "DAC" || a.response_status == "DAD" ? 1 : 0),
                       rightPartyContacts = g.Sum(a => a.response_status == "PTP" || a.response_status == "RPC" ? 1 : 0),
                       promiseToPays      = g.Sum(a => a.response_status == "PTP" ? 1 : 0),
                       talkTime           = g.Sum(a => EntityFunctions.DiffSeconds(a.ov_call_connected_time, a.ov_trunk_released_time)) ?? 0,
                       wrapTime           = g.Sum(a => EntityFunctions.DiffSeconds(a.ov_trunk_released_time, a.record_released_time)) ?? 0
                   };

And this is the query joining them together.

var queryJoin = from qd in queryDownload
                join qp in queryPenData
                on qd.listName equals qp.listName
                select new
                {
                    listName           = qp.listName,
                    download           = qd.totalDownload,
                    dials              = qp.dials,
                    agentConnects      = qp.agentConnects,
                    abandons           = qp.abandons,
                    rightPartyContacts = qp.rightPartyContacts,
                    promiseToPays      = qp.promiseToPays,
                    talkTime           = qp.talkTime,
                    wrapTime           = qp.wrapTime
                };

This seems extremely verbose/roundabout to me. Is there a better way I can write/approach this to shrink/simplify the code?

Answer 1

For your last query could you not just do something like this?

var queryJoin = from qd in queryDownload join qpd in queryPenData on qd.listname equals qpd....

Should be able to do this:

var queryJoin = from qd in queryDownload
            join qp in queryPenData
            on qd.listName equals qp.listName
            select new
            {
                qp, qd
            };

From what I can tell you’ve already formed your data in queryPenData so there is no reason to re-assign it to new variables in the final join. Just select the object which will allow you to traverse into the anonymous type in queryPenData. I think…