Question

I have two tables:

Table1:

RulesVectorID(nullable, primary),Weight,IsDeleted

Table2:

RulesVectorID(forigen) , Weight,IsDeleted, NumberOfOffers, other fields...

I want to do tow things:

1. assign Id to all rows in table1 where RulesVectorID ==null

   I tried this:

   UPDATE myTable1
   SET RulesVectorID = SELECT MAX(RulesVectorID) + 1 FROM myTable1,
   WHERE RulesVectorID IS NULL
   

2. To rows added in step (1) I want to copy their Weight, IsDeleted columns and add 1 to their NumberOfOffers

   I tried this:

   INSERT INTO myTable2 (Weight, IsDeleted, NumberOfOffers, RulesVectorID) 
   VALUES (
     SELECT Weight, IsDeleted, 1, RulesVectorID 
     FROM myTable1 
     WHERE myTable1.RulesVectorID NOT IN (SELECT RulesVectorID FROM myTable2))
   

Is there any cleaner way to do it?

Answer 1

;with t as (
select *, rn=row_number() over (order by weight)
from mytable1
where RulesVectorID is null)
update t set RulesVectorID = rn + isnull((Select max(RulesVectorID) from myTable1),0);

Second query looks ok once you drop the values()

insert into myTable2 (Weight,IsDeleted,NumberOfOffers,RulesVectorID) 
select Weight,IsDeleted,1,RulesVectorID 
from myTable1 
where myTable1.RulesVectorID not in (select RulesVectorID from myTable2)