Question

I have WCF method that looks something like this:

public GetRecordsResponse GetRecords(GetRecordsRequest request)
        {
            GetRecordsResponse response = new GetRecordsResponse();

                Util.GetRecords.VerifyMandatoryParameters(request);
                //make sure mandatory parameters have correct values.
                Util.GetRecords.SetDefaultValues(request);

                Util.GetRecords.SetDefaultResponseValues(request, response);

                DataReader.GetRecords.GetAllRecords(request, response);

            return response;
        }

Is it wrong that i have the entire DAL and many Helper methods as static classes and methods? If so, why?

Answer 1

As a result of using Static method you can access instance variables like properties and fields this means you need to pass the request to every method.

If you used instances of GetRecords you could do somehting liek

   GetRecords gr = new gr();
   gr.Request = request;
   gr.VerifyMandatoryParameters();
   gr.SetDefaultValues();
   gr.SetDefaultResponseValues(response);
   gr.GetAllRecords();

Also if you implment a fluent interfaces you could have written it like this.

   GetRecords gr = new gr();
   gr.SetRequest(request)
     .VerifyMandatoryParameters()
     .SetDefaultValues()
     .SetDefaultResponseValues(response)
     .GetAllRecords();

But there’s nothing “wrong” with what you did