Question

I have written the following mergesort code.

public class mergesort {

    public static int a[];

    public static void merges (int work[], int low, int high) {
        if (low==high)
            return;
        else {
            int mid = (low+high)/2;
            merges(work,low,mid);
            merges(work,mid+1,high);
            merge(work,low,mid+1,high);
        }
    }

    public static void main (String[] args) {
        int a[] = new int[] {64, 21, 33, 70, 12, 85, 44, 99, 36, 108};
        merges(a,0,a.length-1);
        for (int i=0; i<a.length; i++) {
            System.out.println(a[i]);
        }
    }


    public static void merge (int work[], int low, int high, int upper) {
        int j = 0;
        int l = low;
        int mid = high-1;
        int n = upper-l+1;
        while (low<=mid && high<=upper)
            if (a[low] < a[high])
                work[j++] = a[low++];
            else
                work[j++] = a[high++];
        while (low <= mid)
            work[j++]=a[low++];
        while (high <= upper)
            work[j++] = a[high++];
        for (j=0;j<n;j++)
            a[l+j]=work[j];
    }
}

It does not work. After compilation, there is this error:

java.lang.NullPointerException
    at mergesort.merge(mergesort.java:45)
    at mergesort.merges(mergesort.java:12)
    at mergesort.merges(mergesort.java:10)
    at mergesort.merges(mergesort.java:10)
    at mergesort.merges(mergesort.java:10)
    at mergesort.main(mergesort.java:27)

How can this problem be fixed?

Answer 1

You have two arrays called a:

a static, mergesort.a:

public static int a[];

and a local variable in main:

int a[]=new int[]{64,21,33,70,12,85,44,99,36,108};

When you use a in merge, you use the static member, which was never initialized.
It you wanted to initialize mergesort.a, you should have written

a = new int[]{64,21,33,70,12,85,44,99,36,108};

However, that would make merge weird, since it will have work = a as an argument, and reference to the static mergesort.a, which would then be the same array.

Confused? So am I… :)