Question

I have written this function which will set
val=max or min (if val comes null)
or val=val (val comes as an Integer or “max” or “min”)

while calling i am probably sending checkValue(val,”min”) or checkValue(val,”max”)

 public String checkValue(String val,String valType)
 {

   System.out.println("outside if val="+val);

   if(!val.equals("min") && !val.equals("max"))
     {
     System.out.println("Inside if val="+val);

     try{
         System.out.println("*Inside try val="+val);
         Integer.parseInt(val);
         }

     catch(NumberFormatException nFE)
         {
         System.out.println("***In catch val="+val);
         val=valType;
         }

     return val;
     }
     else
     {
       return val;
     }
}

But the problem is if val comes null then
outside if******val=null
is shown.
Can any1 tell me is this a logical mistake?
And why will I correct?

Answer 1

If val is null, then the expression val.equals("min") will throw an exception.

You could correct this by using:

if (!"min".equals(val) && !"max".equals(val))

to let it go inside the if block… but I would personally handle it at the start of the method:

if (val == null) {
  // Do whatever you want
}

Btw, for the sake of readability you might want to consider allowing a little more whitespace in your code… at the moment it’s very dense, which makes it harder to read.