Question

I have xml file

<root>
  <child_1>
    <sub_child attr1="text" attr2="text" />
    <sub_child attr1="text" attr2="text" />
    <sub_child attr1="text" attr2="text" />
  </child_1>    
  <child_2>
    <sub_child attr1="text" attr2="text" />
    <sub_child attr1="text" attr2="text" />
    <sub_child attr1="text" attr2="text" />
  </child_2>    
  <child_3>
    <sub_child_1 attr1="text" attr2="text" />
    <sub_child_2 attr1="text" attr2="text" />
  </child_3>    
  ...

and I want to read sub_child attributes to classes

class SubChild {
  string a1;
  string a2;
}

I need two lists of SubChild objects for child_1 and child_2 and two SubChild objects for sub_child_1 and sub_child_2

Now I use linq to xml and my code is

// List<SubChild> 
var child_1 = from s in doc.Descendants("sub_child").Where(x => x.Parent.Name == "child_1")
              select new SubChild {
                a1 = s.Attribute("attr1").Value,
                a2 = s.Attribute("attr2").Value,
              };

// List<SubChild> 
var child_2 = from s in doc.Descendants("sub_child").Where(x => x.Parent.Name == "child_2")
              select new SubChild {
                a1 = s.Attribute("attr1").Value,
                a2 = s.Attribute("attr2").Value,
              };

// SubChild
var sub_1 = (from s in doc.Descendants("sub_child_1")
              select new SubChild {
                a1 = s.Attribute("attr1").Value,
                a2 = s.Attribute("attr2").Value,
              }).First();

// SubChild
var sub_2 = (from s in doc.Descendants("sub_child_2")
              select new SubChild {
                a1 = s.Attribute("attr1").Value,
                a2 = s.Attribute("attr2").Value,
              }).First();

but it looks ugly and I would like to ask is there more clear way to do this?

Answer 1

You can specify a “Path” using .Element() and .Elements(), eliminating the where lambdas.

 // untested
 var child_1 = from s in doc.Root.Element("child_1").Elements("sub_child")
          select new SubChild {
            a1 = s.Attribute("attr1").Value,
            a2 = s.Attribute("attr2").Value,
          };