Question

I just write a simple operator= in Widget,but when I operator= it ,it throws an Unhandled exception in vs2010.
I don`t see any wrong in these code. needs some help.

 class WidgetImpl
    {
        public:
            WidgetImpl ( int _a, int _b, int _c ) :
                a_ ( _a ), b_ ( _b ), c_ ( _c )
            {
            };
            //WidgetImpl& operator= ( const WidgetImpl& rhs ) {    //if I define this function,everything will be allright.

            //   if ( this == &rhs ) { return *this; }
            ////
            ////.... do something

            ////
            //return *this;
            // }

            int  a_, b_, c_;
            std::vector<double> vector_;
    };


    class Widget
    {
        public:
            Widget () : pImpl_ ( NULL ) {};
            Widget ( const Widget& rhs ) {};
            Widget& operator= ( const Widget& rhs ) 
            {
                if ( this == &rhs ) { return *this; }

                *pImpl_ = * ( rhs.pImpl_ );   
                return ( *this );
            }
            void SetImp ( WidgetImpl* _Impl )
            {
                this->pImpl_ = _Impl;
            }

            WidgetImpl* pImpl_;
    };

    int main ( int argc, char** argv )
    {
        Widget w;
        WidgetImpl* wimpl = new WidgetImpl ( 1, 2, 3 );
        w.SetImp ( wimpl );
        Widget w2;
        w2 = w;  //Unhandled exception throws here

        return 0;
    }

As you can see above.If I define operator= in class WidgetImpl . It seems everything is OK.. weird..

Answer 1

Your w2‘s pImpl_ is null, so assigning to it will result in undefined behaviour (typically, a segmentation violation).

In the code

            *pImpl_ = * ( rhs.pImpl_ );   

the pImpl_ on the LHS is null.