Question

I made a Python script, that reads a text file then goes to a url, and adds the extension in the text file to the url. The problem is the script keeps stopping before it is done reading the file. I cant figure out why.

import urllib
f = open("extension/1.txt", 'r')

for x in f.readline():    
    a = f.readline()
    url = "http://www.link.com/whatever/%s" % a
    print url
    urllib.urlretrieve(url, a) 

Answer 1

By calling for x in f.readline():, you’ll be going through the string that is the first line of the file as an iterable and then grabbing a new line for each character in the first line via a = f.readline(). I don’t think this is your intent.

The file object f is iterable itself, so you can simply do the following:

for line in f:
    value = line.rstrip('\n')
    url = "http://www.link.com/whatever/%s" % value
    print url
    urllib.urlretrieve(url, value)  # Not sure why you want to send value (your a) here