Question

I need to convert CString to BYTE array. I don’t know why, but everything that I found in internet does not work 🙁
For example, I have

CString str = _T("string");

I’ve been trying so
1)

BYTE *pbBuffer = (BYTE*)(LPCTSTR)str;

2)

BYTE *pbBuffer = new BYTE[str.GetLength()+1];
memcpy(pbBuffer, (VOID*)(LPCTSTR)StrRegID, str.GetLength());

3)

BYTE *pbBuffer = (BYTE*)str.GetString();

And always pbBuffer contains just first letter of str

DWORD dwBufferLen = strlen((char *)pbBuffer)+1;

is 2

But if I use const string:

BYTE *pbBuffer = (BYTE*)"string";

pbBuffer contains whole string

Where is my mistake?

Answer 1

Your CString is Unicode (two bytes per character) and you try to interpret it as ANSI (one byte per character). This leads to results you don’t expect.

Instead of casting the underlying buffer into char* you need to convert the data. Use WideCharToMultiByte() for that.