Question

I need to find out best-practice for try-catch when launching a new thread.

Personally, I prefer Option 2.

Which option is the best-practice? Are there any factors that might make either option a best practice in some situations and not others?

Option 1

public void run(){
  try{
     //do something
   }catch(Exception e){
     // log 
   }
}

Option 2

public void run(){
  try{
     //do something
   }catch(Throwable t){
     // log
    }
}

EDIT: Assume that you are writing the code that has to meet a stringent code review.
EDIT 2: I know the difference between the above two options. I am just curious about what is seen as ‘100% correct’ by others.

Answer 1

I would use setDefaultUncaughtExceptionHandler(…) on the thread to catch what the runnable does not handle properly, but when it comes to the runnable itself, it really depends on what it has to achieve and to reasonably anticipate considering a reasonable execution context.

On the other side, creating a separate thread to execute a runnable is not a good strategy IMHO, FutureTask deals with these issues better.