Question

I need to solve a problem like below. I’m not sure, can you suggest better method?

switch(true){
    case $price>100:
        tooHigh(); 
    break;
    case (($price<=100) && ($price>70)):
        negotiate(); 
    break;
    case (($price<=70) && ($price>20)):
        accept(); 
    break;
    case ($price<=20):
        thankAndEscape(); 
    break;
}

Answer 1

if ($price <= 20) {
        thankAndEscape(); 
} elseif ($price <= 70) {
        accept();
} elseif ($price <= 100) {
        negotiate(); 
} else {
        tooHigh(); 
}

1. switch(true) is necessary in a small number of cases; the fact you make the check with expressions inside the case keyword means the syntax does not fit at all, that’s a good reason to use the if…elseif construct.
2. switch…case syntax has higher performances in PHP than if…else in case there’s not a default case, so given the solution I suggest (which has a default case) I would not use the switch…case syntax.
3. By making progressive checks, starting from the lowest price range and increasing it step by step, you don’t have to check for the whole range, since the first point of the interval is surely greater than the last of the previous check. The solution I suggest is simpler and solid, giving moreover better performances.

Try it and post the results/your impressions (information about performances are appreciated 🙂

Cheers!