Question

I need your help. I want to create a little menu with effects slideUp and slideDown.
I’ve found a solution, but i want to ask you if there is a “cleaner” and better solution.

Here’s my Code:

var menu_id = "";
$('.menu li a').click(function(){
    var currentId = $(this).attr('id');
    if(menu_id != ""){
        $('#frame-' + menu_id).slideUp();
    }
    if(currentId != menu_id){
        $('#frame-' + currentId).slideDown();
        menu_id = currentId;
    }
    else{
        menu_id = "blank"
    }
});

Regards
Dario

Answer 1

Based on the post by sp00m try this

$(".menu li a").click(function() {
   var frame = $('#frame-' +  this.id);
   if ($(frame).is(":visible")) {
       $(frame).slideUp();
   }
   else{
       if($("[id^='frame-']:visible").length == 0)
       {
           $(frame).slideDown();
       }
       else if($("[id^='frame-']:visible").length == 1)
       {
           $("[id^='frame-']:visible").slideUp(function(){
               $(frame).slideDown();
           });
       }                   
   }
});