Question

I needed to make my own label to hold some value, that is diferent from the value displayed to user

public class LabelBean : Label {
  private string value;

  public LabelBean(string text = "", string value = ""): base() {
    base.Text = text;
    this.value = value;
  }

  public string Value {
    get { return value; }
    set { this.value = value; }
  }
}

but now id in the form constructor I replace the control with my class

this.lbAttributeType = new LabelBean();

and later after the form is created, but before it is shown I set the text through setter

(this.lbAttributeType as LabelBean).Value = value;
this.lbAttributeType.Text = Transform(value);

but in the form I have always “label1” text… what is wrong with it?
thanks

UPDATE

I added the solution here to find it easier:

public class MyLabel : Label {

    public MyLabel()
      : base() {
    }

    public string Value {
      set {
        this.Text = value;
      }
    }
  }

and the form with Widnows.Forms.Label label1 control

public partial class Form1 : Form {

    public Form1() {
      InitializeComponent();
      this.Controls.Remove(this.label1);
      this.label1 = new MyLabel();
      this.Controls.Add(this.label1);
      (this.label1 as MyLabel).Value = "oh";
    }
  }

the bug was in the Controls.Remove and Controls.Add,
thanks all for their time 🙂

Answer 1

I agree with WoLfulus and Andreas Zoltan and would add a symmetrical functionality to Text if there exists a unambiguous reverse transformation:

public string Value
{
    get { return value; }
    set
    {
        if (this.value != value) {
            this.value = value;
            this.Text = Transform(value);
        }
    }
}

public override string Text
{
    get { return base.Text; }
    set
    {
        if (base.Text != value) {
            base.Text = value;
            this.value = TransformBack(value);
        }
    }
}

Note the if checks in order to avoid an endless recursion.

---

EDIT:

Assigning your label to lbAttributeType is not enough. You must remove the old label from the Controls collection before the assignment and re-add it after the assignment.

this.Controls.Remove(lbAttributeType);  // Remove old label
this.lbAttributeType = new LabelBean(); 
this.Controls.Add(lbAttributeType); // Add new label

Your form was still displaying the old label! Why did I not see it earlier?