Question

I re-posted this question as I think it is a bit vague. New Post

I am currently using a Windows Service that is on a 2 minute timer. I am using EF code first with a repository pattern for data access. I am using Ninject to inject my dependencies. I have the following bindings in my NinjectDependencyResolver class:

ConnectionStringSettings connectionStringSettings = ConfigurationManager.ConnectionStrings["Database"];

Bind<IDatabaseFactory>().To<DatabaseFactory>()
                        .InSingletonScope()
                        .WithConstructorArgument("connectionString", connectionStringSettings.Name);

Bind<IUnitOfWork>().To<UnitOfWork>().InSingletonScope();
Bind<IMyRepository>().To<MyRepository>().InSingletonScope();

When my service runs every 2 minutes I do some thing similar to this:

foreach (var row in rows)
{
    var existing = myRepository.GetById(row.Id);

    if (existing == null)
    {
        existing = new Row();

        myRepository.Add(existing);

        unitOfWork.Commit();
    }
}

I am starting to see an error in my logs that say:

The changes to the database were committed successfully, but an error occurred while updating the object context. The ObjectContext might be in an inconsistent state. Inner exception message: AcceptChanges cannot continue because the object’s key values conflict with another object in the ObjectStateManager. Make sure that the key values are unique before calling AcceptChanges.

Is it correct to use InSingeltonScope when using Ninject in a Windows Service? I believe I tried using different scopes like InTransientScope but I could only get InSingeltonScope to work with data access. Does the error message have anything to do with Scope or is it unrelated?

Answer 1

Assuming that the service is not the only process that operates on the database you shouldn’t use Singleton. What happens in this case is that you are reusing a DBContext that has cached entities which are out of date.

The better way is to treat each timer execution of the service in a similar way like it is a web/wcf request and create a new job processor for the request.

var processor = factory.CreateRowsProcessor();
processor.ProcessRows(rows);

public class RowsProcessor
{
    public Processor(UoW uow, ....)
    {
        ...
    }

    public void ProcessRows(Rows[] rows)
    {
        foreach (var row in rows)
        {
            var existing = myRepository.GetById(row.Id);

            if (existing == null)
            {
                existing = new Row();
                myRepository.Add(existing);

                unitOfWork.Commit();
            }
        }
    }
}

Depending of the problem it might even better to put the loop outside and have a new processor for each single row.

Read http://www.planetgeek.ch/2011/12/31/ninject-extensions-factory-introduction/ for more information about factories. Also have a look at the InCallScope of the named scope extension if you need to inject the UoW into multiple classes. http://www.planetgeek.ch/2010/12/08/how-to-use-the-additional-ninject-scopes-of-namedscope/