Question

I search a JSON tree with jQuery on keyup-event. If the input is equal to the desired entry the input will disabled.

Now I need to call a function if they all are filled and correct. The if queries are long so i have written them into variables.

I’ve tried this, but it fails:

if (simple_present && simple_past && past_participle) {
    alert('All right!');
}

Now, when I write something like this, it works:

if (simple_present || simple_past || past_participle) {
    alert('All right!');
}

Here’s a fiddle of what I have so far.

Any ideas?

BTW: What is the best way to combine long if queries with reg expressions​?

Answer 1

Consider this:

var json = {
    "vocables": {
        "irregular": {
            "sein": {
                "simple_present": "be",
                "simple_past": "was were",
                "past_participle": "been"
            },
            "schlagen": {
                "simple_present": "beat",
                "simple_past": "beat",
                "past_participle": "beaten"
            },
            "werden": {
                "simple_present": "become",
                "simple_past": "became",
                "past_participle": "become"
            }
        }
    }
};

var word = $( 'h1' ).text();

$( 'input' ).on( 'keyup', function () {
    if ( this.value === json.vocables.irregular[ word ][ this.id ] ) {
        $( this ).prop( 'disabled', true ).next( 'input' ).focus();
    }

    if ( $( 'input:not(:disabled)' ).length === 0 ) {
        alert( 'SUCCESS' );
    }
});

Live demo: http://jsfiddle.net/NnAMu/1/

As you can see, I have:

• changed the JSON structure to suit my needs better,
• cached the current word into a variable.

With those changes, the resulting “keyup” handler code is much simpler.