Question

I seem to be getting intermittent problems with my Oracle connection indicating something about a problem with semaphores which suggest that Oracle is somehow holding onto the connections instead of removing them after they have been used.

Here’s the code and connection string I use:

Connection string: user id=user;password=password;data source=dataSource; Validate Connection=true;Min Pool Size=10;Connection Lifetime=5;Connection Timeout=60;Incr Pool Size=5;

And the code I use is this:

Dim OracleConn As New OracleConnection()
Dim DataTable As DataTable
Dim queryOracle As OracleCommand
Dim OracleDataAdapter As OracleDataAdapter
Dim connStr As String = "user id=user;password=password;data source=dataSource; Validate Connection=true;Min Pool Size=10;Connection Lifetime=5;Connection Timeout=60;Incr Pool Size=5;"
OracleConn.ConnectionString = connStr

Try

            OracleConn.Open()

            queryOracle = OracleConn.CreateCommand()

            queryOracle.CommandText = "select * from table1"

            DataTable = New DataTable()
            OracleDataAdapter = New OracleDataAdapter(queryOracle)
            OracleDataAdapter.Fill(DataTable)

            table1.DataSource = DataTable.DefaultView
            table1.DataBind()

        Catch OracleEx As OracleException
            Throw
        Catch ex As Exception
            Throw
        Finally

            If Not OracleConn Is Nothing And OracleConn.State = ConnectionState.Open Then
                OracleConn.Close()
            End If

        End Try

Now my questions are:

1. Is this the best way of doing this?
2. I only “Close” my connection do I need to “Dispose” of it also?

I’m using Oracle.DataAccess.Client by the way.

Any help will be much appreciated

Answer 1

Try to put everything between Using.

Using oracleConn as OracleConnection = new OracleConnection()
'Your stuff goes here
End Using

the same goes for Commands.

P.S. There’s is no need to catch Exception if they are just thrown again.