Question

I tried my level best to write an improved version but failed.

inFiles.ToList().ForEach(i =>
{
    filePath = inFolder + "\\" + i.Value;

    if (i.Key.Equals(replacementFile))
    {
        replacementCollection = GetReplacementDataFromFile(filePath);
    }
    else if (i.Key.Equals(standardizationFile))    
    {
        standardizationCollection = GetStandardizationDataFromFile(filePath);
    }                   
});

The problem is that I cannot use a switch case over here because the comparison variables are not constant.

Kindly help to improve this code.

I am using C#(3.0).

Thanks

Answer 1

The code you have doesn’t have an excessive amount of if’s.

You appear to have three possibilities: Belongs to replacement, belongs to standardization, Belongs to neither of those. What you have is an efficient, readable way to do it.

I’d keep it the way it is.