Question

i try to write a query but my query finished with “Control nvarchar(500), “. i want to finish “Control nvarchar(500)” How can remove “,”, ” “?

 void SqlTable(List listMyColumnNames, string TableName)
        {

            string  Text = "Create table ENG_"+TableName+" (ENG_"+TableName+"_ID integer PRIMARY KEY identity(1,1), ";
            char[] MyChar = {',', ' ' };
            for (int i = 0; i < listMyColumnNames.Count; )
            {
                 Text+=listMyColumnNames[i]+" nvarchar(500), ";
                 if (i == listMyColumnNames.Count-1)
                     Text.TrimEnd(MyChar);
                 i++;
            }
            Text+=" )";

Answer 1

I think you may want to look at String.Join. What you can do is transform your column name strings, containing the SQL definition of your colum, e.g. MyColumnName[1]+" nvarchar(500)", into alistMyColumnDefarray, thenJoin` that array with the comma as a separator.

The benefit:

• no ‘if I’m the last entry’,
• clear separation of your column names and your SQL representation for a column

The drawbacks…. none 🙂

for( String name in listMyColumnNames ) {
   listMyColumnDefs.Add( name + " nvarchar(500)" );
}

String mycolumndef = String.Join( listMyColumnDefs, ", ");