Question

i use this script to download images from the same html page. But if images large enough, this script doesnt download properly – all images are 1,15 Kb and dont display.
How can i fix it? what’s wrong?

Answer 1

If you download and inspect the HTML in http://tema.ru/travel/new-york.2011.11/, you see things like

<img src="IMG_5072.jpg" alt="" width="1000" height="667" border="1" />

So this page is using relative links.

The line

parsed[2] = image["src"]

changes parsed from

['http', 'tema.ru', '/travel/new-york.2011.11/', '', '', '']

to

['http', 'tema.ru', 'IMG_5072.jpg', '', '', '']

and then forms the new url with

url = urlparse.urlunparse(parsed)

which sets url to http://tema.ru/IMG_5072.jpg which does not exist.
The correct url is http://tema.ru/travel/new-york.2011.11/IMG_5072.jpg.

We can form that url with

url = urlparse.urljoin(base_url,image['src'])

so try

"""
http://stackoverflow.com/a/258511/190597
Author: Ryan Ginstrom
dumpimages.py
    Downloads all the images on the supplied URL, and saves them to the
    specified output file ("/tmp" by default)

Usage:
    python dumpimages.py http://example.com/ [output]
"""
import os
import sys
import urllib
import urllib2
import urlparse
import argparse
import BeautifulSoup

def main(base_url, out_folder):
    """Downloads all the images at 'url' to out_folder"""
    soup = BeautifulSoup.BeautifulSoup(urllib2.urlopen(base_url))
    for image in soup.findAll("img"):
        src = image['src']
        print "Image: {s}".format(s=src) 
        _, filename = os.path.split(urlparse.urlsplit(src).path)
        outpath = os.path.join(out_folder, filename)
        url = urlparse.urljoin(base_url, src)
        urllib.urlretrieve(url, outpath)

if __name__ == "__main__":
    parser = argparse.ArgumentParser()
    parser.add_argument('url')
    parser.add_argument('out_folder', nargs = '?', default = '/tmp')
    args = parser.parse_args()
    main(args.url, args.out_folder)