Question

I used to have one function to any select query in my script, but since it’s not secure I need to find out how to make a dynamic PDO class in php.

For example, I used to use this code.

function excute_query ($Query)
{

    if($Query_Run = mysql_query($Query))
    {
        while($DATA = mysql_fetch_array($Query_Run, MYSQL_ASSOC))
            {
                $data_array[] = $DATA;
            }
            return $data_array;
            close();

    }
    else{
            die(mysql_error());
        }

    mysql_close();

}

and I can use it anywhere in my script and it return’s an array with the data. in 2 lines.

$sql = 'SELECT * FROM users';
$users = execute_query($sql);

Now I need to use the same function with PDO. I’ve been trying, but how I can make a class or function to do the same using PDO.

What I’m trying to say. instead of write same 4 lines to make a query, is there any way to make a function or class take a query and return the data ?

Thank you.

Answer 1

A quick and dirty but little verbose solution would be this one

function execute_query( $query, $params ) {
    global $pdo;
    $stmt = $pdo->prepare( $query );
    $stmt->execute($params);
    return $stmt->fetchAll();
}
$users = execute_query('SELECT * FROM users WHERE id=?',array($id));

but personally I hate writing the word array, so, I would use func_get_args() and call this way

function execute_query() {
   global $pdo;
   $args  = func_get_args();
   $query = array_shift($args);
   $stmt  = $pdo->prepare($query);
   $stmt->execute($args);
   return $stmt->fetchAll();
}
$sql   = 'SELECT * FROM users WHERE username=? AND password=?';
$found = execute_query($sql,$username,$password);

But having a class would be apparently better.
It will let you have different functions for the different result sets, like

$username = db::getOne('SELECT name FROM users WHERE id=?',$id);

instead of your current

$user     = execute_query('SELECT name FROM users WHERE id=?',$id);
$username = $user['name'];

or, even more useful ones

$users = db::getIndexed('id','SELECT name FROM users);

to get an array where keys filled with user ids or

$ids = db::getCol('SELECT id FROM users');
$in  = implode(",",$ids);