Question

I using c# winforms and wanted to know how it’s better to write and why.

if(txtName.Text == "John")
    ;

or

String name = txtName.Text
if (name == "John")
    ;

Edit: Thanks guys you helped me a lot!!!

Answer 1

The second version is pointless – it is longer, less readable and introduces one extra variable (though a good compiler would get rid of it, assuming it is not used elsewhere).

Of the two choices, this one is better:

if(txtName.Text == "John")

Though I would go with a third:

if(txtName.Text.Equals("John", StringComparison.InvariantCultureIgnoreCase)

You may want the StringComparison option to be a different enumeration value, depending on how you want the comparison to occur.